openssl_version: Adjust regex to match more openssl version strings #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboyd-m
force-pushed
the
bug/openssl_version
branch
from
2193f97 to
99bd40e
Compare
|
Here is an interactive version that clarifies the groupings: https://regexr.com/8bvn7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Several OSes have openssl built with version strings that do not match, meaning the fact generation utterly fails. There are a few gates in the code around openssl version 1 vs. 3, and these gates then fail as well.
This changes the regex to better group the string as well as match the other OSes.
This Pull Request (PR) fixes the following issues
n/a
As an aside, it seems like we could be adding another fact based on FIPS mode, and possibly the library information for v3, but that is best left to another PR.
Also, if anyone could get the rhel 9 version that would be great.