Update modulesync and fix test #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valantin
force-pushed
the
fix-test
branch
3 times, most recently
from
efd78b4 to
f73954a
Compare
ekohl
reviewed
Apr 10, 2024
| it 'contains the default fstab setting' do | ||
| shell('cat /etc/fstab | grep /tmp/swapfile.fallocate', acceptable_exit_codes: [0]) | ||
| end | ||
| describe file('/etc/fstab'), shell('/sbin/swapon -s') do |
There was a problem hiding this comment.
I don't think you can combine the shell part in here.
Actually, our code doesn't use this a lot but it's recommended to avoid describe $resource() and use:
it 'sets up fstab' do
expect(file('/etc/fstab')).to be_file
.and(have_attributes(content: include('/mnt/swap.1')))
endThere was a problem hiding this comment.
and if I want to check the output of a shell script?
I've tried your example and it fails
-:content => (include "/mnt/swap.1"),
+:content => "# /etc/fstab: static file system information.\n#\n# <file sys>\t<mount point>\t<type>\t<options>\t<dump>\t<pass>\n\n# device during installation: /dev/loop0p1\nUUID=e40706ce-053f-451f-b6fe-0979430677a4\t/\text4\trw,discard,errors=remount-ro\t0\t1\n#VAGRANT-BEGIN\n# The contents below are automatically generated by Vagrant. Do not modify.\n#VAGRANT-END\n",
|
Hello, please advice, is there any chance to get this PR merged? Thank you. Looking forward to seeing first release of this module to be released to Forge. |
|
is this one still needed? if so, please rebase, you seem to have some conflicts now 🙈 |
|
Not needed anymore - thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
update modulesync
This Pull Request (PR) fixes the following issues
Include #5 #6