add journal-remote settings #483
Closed
+159
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trefzer
force-pushed
the
add_journal_remote
branch
3 times, most recently
from
210b804
to
8777432
Compare
trefzer
force-pushed
the
add_journal_remote
branch
from
8777432
to
880b7f3
Compare
Reason: equal options in journal-upload and journal-remote
traylenator
reviewed
Aug 13, 2024
| @@ -1,2 +1,3 @@ | |||
| --- | |||
| systemd::nspawn_package: 'systemd-container' | |||
| systemd::journal_remote::package_name: 'systemd-journal-remote' | |||
There was a problem hiding this comment.
Would be good to add an acceptance test to keep confirming all the package names are correct.
There was a problem hiding this comment.
right, bu was not able to create a succesfull test. I assume, I cannot start systemd-journal-remote service in the environment. I'm giving up now ;(
(see #482 for the commit trying ;))
|
I will include this in merge request #482 because of several merge conflicts and the possibility to use same spec tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, DO NOT MERGE YET
Pull Request (PR) description
add possibility to manage journal-remote (central log server)