Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 12 support #236

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Add Debian 12 support #236

merged 4 commits into from
Oct 29, 2023

Conversation

weaselp
Copy link
Contributor

@weaselp weaselp commented Oct 29, 2023

Debian 11 (bullseye) changed the codename in the security Release file to specify -security instead of just .

For bullseye this was already correctly handled, but for later releases this module would fall back to the earlier style.

Fix origins to add -security for all releases >= bullseye and not just for exactly bullseye.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Peter Palfrader added 2 commits October 29, 2023 09:34
Debian 11 (bullseye) changed the codename in the security Release file
to specify <codename>-security instead of just <security>.

For bullseye this was already correctly handled, but for later releases
this module would fall back to the earlier style.

Fix origins to add -security for all releases >= bullseye and not just
for exactly bullseye.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all that's needed for Debian 12 support? If so, should we change this PR into that? It also means adding it to metadata.json.

manifests/params.pp Outdated Show resolved Hide resolved
weaselp and others added 2 commits October 29, 2023 15:55
Use versioncmp() instead of directly comparing integer representations of the version

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@weaselp
Copy link
Contributor Author

weaselp commented Oct 29, 2023

Is this all that's needed for Debian 12 support? If so, should we change this PR into that? It also means adding it to metadata.json.

Probably. I'm certainly using it on Debian 12. I updated the metadata.

@ekohl ekohl changed the title Fix security origins on Debian releases past bullseye Add Debian 12 support Oct 29, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've updated the PR title to better cover what it's doing.

@ekohl ekohl added the enhancement New feature or request label Oct 29, 2023
@ekohl ekohl merged commit 61c78ca into voxpupuli:master Oct 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants