Test container_podman support in beaker #935
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
foooooooo
branch
5 times, most recently
from
ea653f3
to
0f036d3
Compare
bastelfreak
force-pushed
the
foooooooo
branch
2 times, most recently
from
c1272db
to
765a1e1
Compare
bastelfreak
force-pushed
the
foooooooo
branch
2 times, most recently
from
cbc2790
to
ae46bf8
Compare
bastelfreak
force-pushed
the
foooooooo
branch
5 times, most recently
from
9ee865e
to
ce0e0f5
Compare
bastelfreak
force-pushed
the
foooooooo
branch
from
ce0e0f5
to
85eebc1
Compare
bastelfreak
changed the title
evgeni
reviewed
Sep 21, 2024
| @@ -6,7 +6,7 @@ | |||
| # In Puppet 7 the locale ends up being C.UTF-8 if it isn't passed. | |||
| # This locale doesn't exist in EL7 and won't be supported either. | |||
| # At least PostgreSQL runs into this. | |||
| ENV['LANG'] = 'en_US.UTF-8' if host['hypervisor'] == 'docker' && host['platform'] == 'el-7-x86_64' | |||
| ENV['LANG'] = 'en_US.UTF-8' if host['hypervisor'] =~ %r{docker} && host['platform'] == 'el-7-x86_64' | |||
There was a problem hiding this comment.
should this be =~ container? not sure what exactly is the value in hypervisor here.
There was a problem hiding this comment.
I also don't know. I didn't pay too much attention because I want to merge #970 first, and that will remove the whole line anyways.
There was a problem hiding this comment.
fair.
it still would be good to know as I think we use similar blocks in other modules too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues