Add configuration parameters to server and agent #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you add the Type to parameter added in this PR? |
githubgehrmann
force-pushed
the
add-configuration-parameters-to-server-and-agent
branch
2 times, most recently
from
f4f8610 to
a05e0cd
Compare
githubgehrmann
force-pushed
the
add-configuration-parameters-to-server-and-agent
branch
from
a05e0cd to
2899ecb
Compare
- Server: - making StartHistoryPollers configurable - adding TrendFunctionCacheSize parameter to config file - Agent: - adding controlsocket and persistantbuffer parameters
githubgehrmann
force-pushed
the
add-configuration-parameters-to-server-and-agent
branch
from
2899ecb to
8b86dea
Compare
|
All added parameters have a type specified. |
|
Hello, |
|
Hello, |
Valantin
requested changes
Nov 23, 2024
| @@ -179,6 +184,7 @@ | |||
| $server = $zabbix::params::agent_server, | |||
| $listenport = $zabbix::params::agent_listenport, | |||
| $listenip = $zabbix::params::agent_listenip, | |||
| Optional[Integer] $statusport = $zabbix::params::agent_statusport, | |||
There was a problem hiding this comment.
Can you add the declaration of the valid interval?
Optional[Integer[1024,32767]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
We'd like to use this Puppet module to deploy our Zabbix infrastructure but to fully configer it for our needs there are missing some parameters. Im not able to fully test my additions, so a code review and/or testing is recommended.
Following parameters where added
This Pull Request (PR) fixes the following issues
n.a.