Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 4 new 7+ server parameters #978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

trenta
Copy link

@trenta trenta commented Oct 24, 2024

Pull Request (PR) description

This PR enables 4 new server parameters for version >= 7
StartAgentPollers
StartHTTPAgentPollers
StartSNMPPollers
MaxConcurrentChecksPerPoller

@trenta trenta force-pushed the master branch 3 times, most recently from 75f68d9 to 1785781 Compare October 24, 2024 22:00
@fraenki
Copy link
Member

fraenki commented Dec 16, 2024

REFERENCE.md is outdated; to regenerate: bundle exec rake strings:generate:reference

@trenta Please fix the test failure(s) and force-push to trigger the test suite :)

@trenta
Copy link
Author

trenta commented Dec 17, 2024

Is that what you were after?

@fraenki
Copy link
Member

fraenki commented Dec 17, 2024

Looks better now, but almost all tests for Zabbix 7.0 are failing. Looking at this example, the reason is probably always the same:

  deploys a zabbix 7.0 server
    behaves like an idempotent resource
...
  Notice: /Stage[main]/Zabbix::Repo/Yumrepo[zabbix]/baseurl: baseurl changed 'https://repo.zabbix.com/zabbix/6.0/rhel/8/$basearch/' to 'https://repo.zabbix.com/zabbix/7.0/rhel/8/$basearch/'
...

  Error: /Stage[main]/Zabbix::Server/Service[zabbix-server]: Failed to call refresh: Systemd restart for zabbix-server failed!
  journalctl log for zabbix-server:
  -- Logs begin at Tue 2024-12-17 04:10:07 UTC, end at Tue 2024-12-17 04:12:37 UTC. --
  Dec 17 04:12:28 rocky8-64-puppet8.example.com systemd[1]: Starting Zabbix Server...
  Dec 17 04:12:28 rocky8-64-puppet8.example.com zabbix_server[3919]: Starting Zabbix Server. Zabbix 6.0.36 (revision 6bcc7a62c0e).

Although the test is expected to setup Zabbix Server 7.0, it ends up starting version 6.0.36. I assume that this has always been the case, but this PR added options that are only available in version 7 and up, making this issue visible.

Could you probably have a look at the tests?

@trenta
Copy link
Author

trenta commented Dec 18, 2024

I'm happy to participate in a fix but not sure it should be part of this pr. I haven't had any experiences with test coding. I had a look though and to me it looks like server version 6.0 is the only version for testing. If we are to add a very 7 as well would we need to make sure the correct tests are associated with correct version? This is where I'm not sure and don't wan to break things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants