Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile vpkg with V 0.2.2 (a761f68) #38

Merged
merged 6 commits into from
Apr 18, 2021
Merged

Compile vpkg with V 0.2.2 (a761f68) #38

merged 6 commits into from
Apr 18, 2021

Conversation

torbencarstens
Copy link
Contributor

This PR is based on #36 from islonely.

Successfully compiled with a761f68 (see CI pipeline)

Some small comments on changes I did:

os.exec -> os.execute

os.exec has been renamed to os.execute and returns an os.Result now instead of an optional.
u/islonely changed returns from the functions with os.exec, I've ignored them in this update. This should definitely be checked though. All functions which use os.execute should either return an os.Result or some other indication, e.g. return a tuple of (int, string) where int = os.Result.exit_code.

Returning ? from functions

A proper error should be returned so that the user can be shown that one. Each layer should probably add to the error message before propagating it (depending on the path).

Remove tests from CI

I can't access the old CI logs and can't imagine how this should work without tests.

@nedpals nedpals merged commit 3e6b43c into vpkg-project:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants