Compile vpkg with V 0.2.2 (a761f68) #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #36 from islonely.
Successfully compiled with a761f68 (see CI pipeline)
Some small comments on changes I did:
os.exec -> os.execute
os.exec
has been renamed toos.execute
and returns anos.Result
now instead of an optional.u/islonely changed returns from the functions with
os.exec
, I've ignored them in this update. This should definitely be checked though. All functions which useos.execute
should either return anos.Result
or some other indication, e.g. return a tuple of(int, string)
whereint = os.Result.exit_code
.Returning
?
from functionsA proper error should be returned so that the user can be shown that one. Each layer should probably add to the error message before propagating it (depending on the path).
Remove tests from CI
I can't access the old CI logs and can't imagine how this should work without tests.