Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UnityPackage Action でとりあえず EditMode Tests まで走らせる #2271

Merged
merged 15 commits into from
Mar 27, 2024

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented Mar 27, 2024

  • -runEditorTests が廃止されているので自分でテストランナーを定義して -executeMethod する必要がある
    • ただし自由度が上がったので、終了コードをどう返すかなどの設計がしやすくなった
    • 今回は失敗したら終了コード 1 を返すようにした

コミットログが汚いのでこれは squash merge します

@Santarh Santarh requested a review from ousttrue March 27, 2024 12:12

if (Application.isBatchMode)
{
EditorApplication.Exit(result.FailCount > 0 ? 1 : 0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batchMode 起動のときに fail したテストがあったら終了コード 1 を返す

Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Santarh Santarh merged commit 69c518c into master Mar 27, 2024
3 checks passed
@Santarh Santarh deleted the workflow-wip branch March 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants