[exporter] renderer の export しない基準 GameObject.active / Renderer.enabled を修正 #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x.gameObject.activeInHierarchy && x.TryGetComponent<Renderer>(out var renderer) && renderer.enabled) mesh の export 条件と renderer の export 条件が別であることに注意。gltf の node.mesh
ousttrue
added
importer
exporter
Expression(BlendShape)
Santarh
approved these changes
Sep 26, 2024
| @@ -162,7 +162,7 @@ async Task<BlendShapeClip> LoadBlendShapeBind(glTF_VRM_BlendShapeGroup group, Di | |||
| // fallback | |||
| asset.Preset = CachedEnum.ParseOrDefault<BlendShapePreset>(group.name, true); | |||
| } | |||
| asset.Values = group.binds.Select(x => | |||
| asset.Values = group.binds.Where(x => x.mesh >= 0 && x.mesh < Meshes.Count).Select(x => | |||
ousttrue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2437
fixed #2434
fixed #1980
export 時の renderer の export 基準を徹底した。
関連して firstPerson.annotations と expression.binds の mesh/node が連動するのだけど、
残るバグがあった。
既存のモデルに firstPerson.annotations と expression.binds の無効な参照が残っている場合向けに
importer のチェックを追加した。