[lookat] inputMaxValue == 0 の例外処理 #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
commented
Oct 7, 2024
| @@ -9,8 +7,6 @@ namespace UniVRM10 | |||
| [Serializable] | |||
| public class CurveMapper | |||
| { | |||
| private AnimationCurve _curve = AnimationCurve.Linear(0, 0, 1.0f, 1.0f); | |||
There was a problem hiding this comment.
1.0 ではカーブを使わなくなりました。
入力値と同じ値を出力する linear 設定になっています。
0b5vr
reviewed
Oct 7, 2024
| } | ||
| return Curve.Evaluate(src / CurveXRangeDegree) * CurveYRangeDegree; | ||
| // https://github.com/vrm-c/UniVRM/issues/2452 | ||
| var t = Mathf.Clamp01(Mathf.Clamp(src, 0, 1) / MathF.Max(CurveXRangeDegree, 0.001f)); |
There was a problem hiding this comment.
Suggested change
| var t = Mathf.Clamp01(Mathf.Clamp(src, 0, 1) / MathF.Max(CurveXRangeDegree, 0.001f)); | |
| var t = Mathf.Clamp01(src / MathF.Max(CurveXRangeDegree, 0.001f)); |
0b5vr
reviewed
Oct 7, 2024
|
中止 |
Co-authored-by: 0b5vr <0b5vr@0b5vr.com>
0b5vr
reviewed
Oct 11, 2024
Co-authored-by: 0b5vr <0b5vr@0b5vr.com>
0b5vr
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2452