[1.0] Expression の override と binary の組み合わせの挙動を実装 #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
force-pushed
the
fix/expression_override
branch
from
2b0cba9
to
ee4f3a0
Compare
ousttrue
changed the title
ousttrue
force-pushed
the
fix/expression_override
branch
from
ee4f3a0
to
8f3cb87
Compare
ousttrue
added
Expression(BlendShape)
ousttrue
commented
Oct 21, 2024
| if (blinkMultiplier < 1.0f) | ||
| { | ||
| actualWeights[key] = 0.0f; | ||
| } |
There was a problem hiding this comment.
isBinaryが指定されている表情が他の表情からオーバーライドの影響を受ける場合、受けている影響が0.0より大きければ、完全に抑制されなければいけません（MUST）。
に関しては既存実装で実現できているように見えたので特に変更していません。
を実装しました。 |
|
isBinaryの表情がoverrideを行う場合ならびにisBinaryの表情がoverrideされる場合のサンプルモデルを作成しました。
UniVRMにおいて、同じaccessorが複数のメッシュで用いられている場合にUVのY-flipがうまく動作しないことがある問題があり、現状本モデル群は意図通りに動作していません。
|
0b5vr
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2430
vrm-c/vrm-specification#487
および
Assets/VRM10_Samples/VRM10Viewerに expression 実験用の UI を追加しました