[export][springbone] bake 時に SpringBone と LookAt に反映する実装 #2468
+206
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
added
exporter
SpringBone
LookAt/FirstPerson
ousttrue
force-pushed
the
fix/impl_springbone_bake
branch
from
e1fb3f6
to
56b3024
Compare
|
rebase しました 🙏 |
ousttrue
commented
Oct 21, 2024
| @@ -208,8 +208,11 @@ private static byte[] Export( | |||
|
|
|||
| if (settings.PoseFreeze) | |||
| { | |||
| // 正規化 | |||
| VRMBoneNormalizer.Execute(target, settings.ForceTPose, settings.FreezeMeshUseCurrentBlendShapeWeight); | |||
| using (var backup = new VrmGeometryBackup(target)) | |||
There was a problem hiding this comment.
using の最初に SpringBone 関連の world 位置を記録。
Dispose で復帰(正規化で変わっている可能性がある)。
ousttrue
commented
Oct 21, 2024
| // SkinnedMeshRenderer.sharedMesh と MeshFilter.sharedMesh を新しいMeshで置き換える | ||
| BoneNormalizer.Replace(root, newMeshMap, m_settings.FreezeMeshKeepRotation); | ||
| } | ||
| using (var backup = new Vrm10GeometryBackup(root)) |
There was a problem hiding this comment.
using の最初に SpringBone 関連の world 位置を記録。
Dispose で復帰(正規化で変わっている可能性がある)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freeze_pose 時に SpringBone と LookAtOffset を反映する機能を実装しました。
fixed #2426
fixed #2277
fixed #2368