Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vrm10][Importer引数] ScriptedImpoter からの Import で SpringBone の初期化を回避する #2473

Merged
merged 4 commits into from
Oct 25, 2024
Merged

[vrm10][Importer引数] ScriptedImpoter からの Import で SpringBone の初期化を回避する #2473

merged 4 commits into from
Oct 25, 2024

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Oct 23, 2024 •
edited
Loading 

A Native Collection has not been disposed, resulting in a memory leak. Allocated from:
  • export 用の copy されたヒエラルキーの springbone が活動してしまう
  • play 時に asset import すると、意図しない springbone の初期化が動作してしまう

に対処しました、
主にSpringBone の初期化フェーズを importer 内に移動したことが、影響しています。

@ousttrue ousttrue added this to the next export bake 関連 milestone Oct 23, 2024
@ousttrue ousttrue changed the title [vrm10] ScriptedImpoter からの Import で SpringBone の初期化を回避する [vrm10][Importer引数] ScriptedImpoter からの Import で SpringBone の初期化を回避する Oct 23, 2024
@ousttrue ousttrue requested a review from Santarh October 23, 2024 06:56
@ousttrue ousttrue changed the title [vrm10][Importer引数] ScriptedImpoter からの Import で SpringBone の初期化を回避する [WIP][vrm10][Importer引数] ScriptedImpoter からの Import で SpringBone の初期化を回避する Oct 23, 2024
@ousttrue ousttrue changed the title [WIP][vrm10][Importer引数] ScriptedImpoter からの Import で SpringBone の初期化を回避する [vrm10][Importer引数] ScriptedImpoter からの Import で SpringBone の初期化を回避する Oct 24, 2024
@mojopon mojopon mentioned this pull request Oct 24, 2024
Merged
@s-iwaki-d s-iwaki-d requested review from mojopon and removed request for Santarh October 24, 2024 10:09
mojopon
mojopon approved these changes Oct 25, 2024
View reviewed changes
Copy link

@mojopon mojopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点だけ気になった点コメントしましたが、修正自体はLGTMなのでApprove

ProjectSettings/QualitySettings.asset
@@ -230,6 +230,7 @@ QualitySettings:
PSM: 5
PSP2: 2
Samsung TV: 2
Server: 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpringBoneとは関係なさそうな修正が入っている？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ。
まぁ、いいか 🙏

@ousttrue ousttrue merged commit 7dc74ea into vrm-c:master Oct 25, 2024
1 check passed
@ousttrue ousttrue deleted the fix/vrm10_asset_import_flag branch October 25, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojopon mojopon mojopon approved these changes

Assignees
No one assigned
Labels
1.0 Non breaking changes SpringBone
Projects
None yet
Milestone
v0.127.2 BlendShape, Center bug fix
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @mojopon