[vrm10] vrmlib による mesh 処理を gltf/vrm0.x のものと同じものに #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
changed the title
ousttrue
commented
Nov 1, 2024
| @@ -3,7 +3,6 @@ | |||
| using System.Linq; | |||
| using UniGLTF.Extensions.VRMC_vrm; | |||
| using UnityEngine; | |||
| using VrmLib; | |||
There was a problem hiding this comment.
using VrmLib を減らしていく
ousttrue
commented
Nov 1, 2024
| @@ -38,18 +35,5 @@ async void Run() | |||
| Debug.Log($"write : {path}"); | |||
| File.WriteAllBytes(path, exportedBytes); | |||
| } | |||
|
|
|||
| static void Printmatrices(Model model) | |||
There was a problem hiding this comment.
未使用の debug print ぽい
ousttrue
commented
Nov 1, 2024
| // ヘビーなため、別スレッドで Run する. | ||
| await awaitCaller.Run(() => | ||
| { | ||
| // bin に対して右手左手変換を破壊的に実行することに注意 !(bin が変換済みになる) |
Santarh
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2474
vrmlib は少しずつ削除していこうと思っております。
とりあえず importer から削除。
1.0 は当初 vrmlib を主流に vrm-0.x 系の mesh 処理は置き換える予定だったのだけど、
あとから glb/vrm-0.x の importer も刷新されて良くなりました。
メンテナンスコスト削減のため vrmlib の方を削除して一本化する方針です。
で使っているところがあるのでまだ削除はできません。