Skip to content

Conversation

@dg0yt
Copy link

@dg0yt dg0yt commented Oct 18, 2025

Description

This PR adopts the boolean CMake option in combination with #cmakedefine01 for the VSG_SUPPORTS_ShaderCompiler and VSG_SUPPORTS_Windowing options.
This pattern is already in use for VSG_SUPPORTS_ShaderOptimizer. It makes it easy to discover the boolean nature of the option, and it makes it hard to pass an unsuitable value. (This PR is triggered by unexpected trouble from using -DVSG_SUPPORTS_Windowing=ON`.)

Type of change

  • Non-breaking change which facilitates configuration.
  • A documentation update might not be needed.

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant