fix: clang-warnings #1626
Merged
fix: clang-warnings #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnyOldName3
reviewed
Dec 16, 2025
| size_t numNegativeDistances = 0; | ||
| size_t numPositiveDistances = 0; | ||
| size_t numZeroDistances = 0; | ||
| [[maybe_unused]] size_t numZeroDistances = 0; |
Contributor
There was a problem hiding this comment.
Suppressing the warning with an attribute is still a bad idea. Either we figure out what the variable was intended to be used for and use it for that, or we get rid of it.
Collaborator
There was a problem hiding this comment.
I have done a code review and just removed the numZeroDistances related code.
Collaborator
|
These changes with the numZeroDistances code removal by me are now merged with VSG master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fix warnings compiling with clang-21 on windows
Depends upon #1625 - marked Draft until that one is merged.
Fixes # (issue)
Type of change
How Has This Been Tested?
cmake -B build . -G "Ninja Multi-Config"cmake --build build -C ReleaseTest Configuration:
cmakeversion3.31.6ninjaversion1.21.1clangversion21.1.7