Fix: Ingress references wrong service under certain conditions #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgubler
force-pushed
the
golang-upgrade
branch
from
012ee11
to
ba11ef3
Compare
davidgubler
force-pushed
the
golang-upgrade
branch
from
fe667be
to
bf0d42b
Compare
davidgubler
force-pushed
the
golang-upgrade
branch
from
bf0d42b
to
1d7553a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where an ingress would reference the wrong service object under certain conditions (more than one service object present).
This is actually fixed by upgrading to Go 1.22, since this problem was caused by weird handling of loop variables in older Go versions.