Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Secret references must be sorted to ensure stable output #134

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: Secret references must be sorted to ensure stable output #134

merged 1 commit into from
Jul 5, 2024

Conversation

davidgubler
Copy link
Member

@davidgubler davidgubler commented Jul 5, 2024 •
edited
Loading

Internal ticket APPX-132

@davidgubler davidgubler requested a review from a team July 5, 2024 08:42
mhutter
mhutter approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mhutter mhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Surely there must be a straight-forward way to collect all keys from a map?"

5 minutes of googling later: 🤦‍♂️

@davidgubler davidgubler merged commit 31eb761 into master Jul 5, 2024
4 checks passed
@davidgubler
Copy link
Member Author

Thanks @mhutter !

@davidgubler davidgubler deleted the fix-ref-ordering branch July 5, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutter mhutter mhutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgubler @mhutter