Add support for "fieldRef" environment variables #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's necessary to expose certain pod metadata (e.g. its IP) as environment variables. To achieve this, Kubernetes provides the so-called "downward API" [1]. This commit allows users to make use of this API in a similar way we implemented references to existing secrets. [1]: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/ Signed-off-by: Manuel Hutter <manuel@hutter.io>
|
Looks reasonable, however one thing I would do is to also add |
`_ref_` will keep working as is; for now there also is no way to differentiate between usages of _ref_ and _secretRef_ Signed-off-by: Manuel Hutter <manuel@hutter.io>
|
Yes that makes sense, implemented in 98f3ed1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's necessary to expose certain pod metadata (e.g. its IP) as
environment variables. To achieve this, Kubernetes provides the
so-called "downward API" 1.
This commit allows users to make use of this API in a similar way we
implemented references to existing secrets.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog