Skip to content

Comments

Action level lock#336

Open
kikimych wants to merge 2 commits intomasterfrom
action_level_lock
Open

Action level lock#336
kikimych wants to merge 2 commits intomasterfrom
action_level_lock

Conversation

@kikimych
Copy link
Contributor

@kikimych kikimych commented Nov 1, 2022

Improved multiple user support. Replaced command level lock on the debug server with action level lock.

@kikimych kikimych force-pushed the action_level_lock branch 3 times, most recently from 30b4dd7 to dd5170d Compare November 25, 2022 17:50
@johnny-keker
Copy link
Contributor

I am facing some issues with, as far as I understand, lock releasing and re-acquiring. All details are on the screenshot below.

  1. First instance of VS starts test action
  2. Second instance of VS starts test2 action (in less then 5 seconds after first one)

master behavior (not correct)

file.txt is overridden by the test2 and we see NOT_OK in first VS instance

Expected behavior

test2 is waiting when test is over, so we see OK in 1st VS instance, but file contents will be NOT_OK after test2 executed

Actual behavior

For some reason, it waits for 10 seconds no matter what and then displays Unable to acquire lock error

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants