Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: fix tests after region check #12

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Test: fix tests after region check #12

merged 1 commit into from
Feb 8, 2024

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Feb 8, 2024

What is the purpose of this pull request?

After the inclusion of the region check, some tests ended up failing. This PR fixes them.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • Chore (changes configuration files, GitHub workflows, etc.)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@hcaula hcaula self-assigned this Feb 8, 2024
Copy link

vtex-io-ci-cd bot commented Feb 8, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation

Copy link
Contributor

@rodorgas rodorgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hcaula hcaula merged commit 53780a1 into main Feb 8, 2024
3 checks passed
Copy link

vtex-io-ci-cd bot commented Feb 8, 2024

Your PR has been merged! App is being published. 🚀
Version 0.7.3 → 0.7.4

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.adserver-resolver@0.7.4

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants