Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct not found message #15

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix: correct not found message #15

merged 2 commits into from
Jul 9, 2024

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Jul 8, 2024

What is the purpose of this pull request?

The AdServer has changed its "Not found" message, so we were throwing an error if the query didn't return a sponsored product.

This didn't affect any store, since there's a safeguard on Intelligent Search API that always returns [] if any error occurs in the Ad Server resolver call.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • Chore (changes configuration files, GitHub workflows, etc.)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@hcaula hcaula self-assigned this Jul 8, 2024
Copy link

vtex-io-ci-cd bot commented Jul 8, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@hcaula hcaula force-pushed the fix/not-found-message branch from 52de0ab to cf451fb Compare July 9, 2024 13:11
@hcaula hcaula merged commit 2abcede into main Jul 9, 2024
2 checks passed
@hcaula hcaula deleted the fix/not-found-message branch July 9, 2024 13:12
Copy link

vtex-io-ci-cd bot commented Jul 9, 2024

Your PR has been merged! App is being published. 🚀
Version 2.1.0 → 2.1.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.adserver-resolver@2.1.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant