Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add condition for "manage-organization" permission #121

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

ilyarudyi
Copy link
Contributor

@ilyarudyi ilyarudyi commented Aug 3, 2023

What problem is this solving?

In our production case, we need to have the role/permission to be able to edit, delete, and add new users in any category (sales or Customers).

We achieved the desired behavior by adding a handler for manage-organization permission.

If the user has the role with manage-organization permission he should be able to:

  • add, edit, or delete a user from any category;
  • can set any role (not only by his category);

How to test it?

Workspace

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Aug 3, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Aug 3, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

1 similar comment
@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Aug 3, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@arturmagalhaesjr arturmagalhaesjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it.
LGTM

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 48, PR deletions = 22

Generated by 🚫 dangerJS against 4bf983c

@ilyarudyi
Copy link
Contributor Author

@arturmagalhaesjr @wender Hi, guys, I update the changelog can you take a look one more time and if all is good to approve? thanks 🤗

@ilyarudyi
Copy link
Contributor Author

ilyarudyi commented Aug 10, 2023

I think the user with manage-organization permission should be able to change or add any role to a new or existing user, so I added this ability. Thanks

(And sorry, I pass a bad url in the PR description, fixed now)

@wender wender merged commit eb45a61 into vtex-apps:master Aug 11, 2023
15 of 17 checks passed
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Aug 11, 2023

Your PR has been merged! App is being published. 🚀
Version 1.26.1 → 1.26.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-organizations@1.26.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants