Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/save edit address data admin #160

Merged

Conversation

Josmar-jr
Copy link
Contributor

@Josmar-jr Josmar-jr commented May 28, 2024

What problem is this solving?
Previously it was not possible to save, edit and delete a new cost center address by confirming the addition in the modal

How to test it?
Log in to your store admin account, access the "aplicativos->organizações->centro de custos->Detalhes do centro de custo" page, enter a registered cost center and try to add or edit or delete an address.

Workspace

Screenshots or example usage:
Screen Recording 2024-05-28 at 15.53.55.zip

Screenshot 2024-05-28 at 15 59 26 Screenshot 2024-05-28 at 15 59 06 Screenshot 2024-05-28 at 15 58 55 Screenshot 2024-05-28 at 15 58 49

Describe alternatives you've considered, if any.
It is now possible for the user to save an address to the cost center immediately after adding, editing and deleting on admin

Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)

Copy link

vtex-io-ci-cd bot commented May 28, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Jun 5, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 109, PR deletions = 7

Generated by 🚫 dangerJS against e55e7c6

@ataideverton ataideverton merged commit 6325a8c into vtex-apps:master Jun 5, 2024
17 of 19 checks passed
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.5% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants