Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/search list many orgs modal #164

Merged

Conversation

Josmar-jr
Copy link
Contributor

What problem is this solving?

Before, it was not possible to filter the organization according to the value entered in the input at change organization modal

How to test it?

  1. Navigate to Workspace
  2. Select the settings option in tabs
  3. Enable "Usar modal para trocar de organização"
  4. Navigate to Workspace
  5. Do the login
  6. Click on the button "Mudar organização"
  7. Dispatch a new search at input

Workspace

Screenshots or example usage:

Screenshot 2024-07-03 at 10 24 01 Screenshot 2024-07-03 at 10 23 46

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link

vtex-io-ci-cd bot commented Jul 3, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 3, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ArthurTriis1 ArthurTriis1 self-requested a review July 9, 2024 15:41
Copy link
Contributor

@ArthurTriis1 ArthurTriis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce the issue and enabled the modal in the admin panel.

Screenshot 2024-07-09 at 13 24 13

However, the modal button does not appear.

Screenshot 2024-07-09 at 13 23 02

Is there anything else I need to configure?

@Josmar-jr
Copy link
Contributor Author

@ArthurTriis1 just enabling the modal should work

@ArthurTriis1
Copy link
Contributor

@ArthurTriis1 just enabling the modal should work

Ok, I will try again, but the current workspace is broken, can you fix it?
Screenshot 2024-07-12 at 09 49 22

@Josmar-jr
Copy link
Contributor Author

@ArthurTriis1 Here it is working normally. Please check if the project branch is up to date
Screenshot 2024-07-12 at 10 09 47
Screenshot 2024-07-12 at 10 11 04

@ArthurTriis1
Copy link
Contributor

ArthurTriis1 commented Jul 12, 2024

@ArthurTriis1 Here it is working normally. Please check if the project branch is up to date

It is working now! And I could test the modal, it is working fine! I will approve, can you can update the changelog?

Copy link

github-actions bot commented Jul 17, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 41, PR deletions = 25

Generated by 🚫 dangerJS against 070774a

CHANGELOG.md Outdated Show resolved Hide resolved
@Josmar-jr
Copy link
Contributor Author

I took the CHANGELOG from the master branch and added the feat from this PR, right?
@ArthurTriis1

Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
21.4% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

@ArthurTriis1 ArthurTriis1 merged commit 98472aa into vtex-apps:master Jul 17, 2024
25 of 29 checks passed
Copy link

vtex-io-ci-cd bot commented Jul 17, 2024

Your PR has been merged! App is being published. 🚀
Version 1.31.11 → 1.32.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-organizations@1.32.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants