Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/list custom fields cost centers #165

Merged

Conversation

Josmar-jr
Copy link
Contributor

@Josmar-jr Josmar-jr commented Jul 11, 2024

What problem is this solving?

Now, it`s possible list custom fields by cost centers and not by organization

How to test it?

  1. Navigate to Workspace
  2. Select the custom center at dropdown
  3. Add new field on "ADD FIELD"
  4. Edit the new field and name fill in and enable "Use no registration"
  5. Save the changes on "SAVE SETTINGS"
  6. Go to storefront and click in "Organization SignUp"
  7. Fill in all fields including the custom cost center field
  8. Back to admin and access Workspace

Workspace

Screenshots or example usage:

Screenshot 2024-07-11 at 11 44 01

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link

vtex-io-ci-cd bot commented Jul 11, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@ArthurTriis1 ArthurTriis1 self-requested a review July 15, 2024 15:00
@ArthurTriis1
Copy link
Contributor

I'm trying to test the PR on the workspace, but when I access the Request Page, the Cost Center custom fields are not displayed, and the getCostCentersByOrganizationId function is not executed. Is this the correct workspace to test?

Screenshot 2024-07-15 at 12 43 23

@Josmar-jr
Copy link
Contributor Author

Josmar-jr commented Jul 16, 2024

adjusted error, please repeat the test
@ArthurTriis1

Copy link

github-actions bot commented Jul 17, 2024

Warnings
⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 217, PR deletions = 145

Generated by 🚫 dangerJS against e0d74e4

@ArthurTriis1
Copy link
Contributor

Hey Josmar, I tried to repeat the test, but the results are the same. For example, I accessed the request described, but the custom fields are not displayed.

Screenshot 2024-07-17 at 09 09 20

CHANGELOG.md Outdated Show resolved Hide resolved
@Josmar-jr
Copy link
Contributor Author

I took the CHANGELOG from the master branch and added the feat from this PR, right?
@ArthurTriis1

@ArthurTriis1
Copy link
Contributor

I took the CHANGELOG from the master branch and added the feat from this PR, right? @ArthurTriis1

Yes, it is correct, but I still cannot see the custom fields for cost centers in the preview.

@ArthurTriis1 ArthurTriis1 self-requested a review July 18, 2024 13:32
@ArthurTriis1
Copy link
Contributor

I took the CHANGELOG from the master branch and added the feat from this PR, right? @ArthurTriis1

Yes, it is correct, but I still cannot see the custom fields for cost centers in the preview.

Checked It again, and now the Cost Center Fields are displayed, thank you!
Screenshot 2024-07-18 at 10 34 24

Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.3% Duplication on New Code (required ≤ 15%)

See analysis details on SonarCloud

@ArthurTriis1 ArthurTriis1 merged commit 65d063a into vtex-apps:master Jul 18, 2024
17 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Jul 18, 2024

Your PR has been merged! App is being published. 🚀
Version 1.32.0 → 1.33.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-organizations@1.33.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants