Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement pagination for sellers in Organization Details page #167

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

icaroov
Copy link
Contributor

@icaroov icaroov commented Aug 2, 2024

What problem is this solving?

On the B2B Organization Details Screen, the view of salespeople is limited to the first 100 records. This limit prevents users from selecting salespeople who are not among the first 100.

How to test it?

Go to Applications and in the ORGANIZATIONS AND B2B COST CENTERS subcategory and click on Organizations. Then, click on an Organization and go to the Sellers tab:

image

Workspace

Screenshots or example usage:

image

How does this PR make you feel? 🔗

Copy link

vtex-io-ci-cd bot commented Aug 2, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Aug 2, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 100, PR deletions = 23

Generated by 🚫 dangerJS against 03fec4b

@ArthurTriis1
Copy link
Contributor

Good job! Could you resolve the conflicts on changelog and I will merge?

@icaroov
Copy link
Contributor Author

icaroov commented Aug 7, 2024

This implementation depends on the PR: vtex-apps/b2b-organizations-graphql#168.

Copy link

sonarcloud bot commented Aug 12, 2024

@enzomerca enzomerca merged commit b8eaa7c into vtex-apps:master Aug 20, 2024
19 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Aug 20, 2024

Your PR has been merged! App is being published. 🚀
Version 1.33.1 → 1.34.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-organizations@1.34.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants