Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and reorder translations #171

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Fix and reorder translations #171

merged 5 commits into from
Sep 5, 2024

Conversation

GeorgeLimaDev
Copy link
Contributor

@GeorgeLimaDev GeorgeLimaDev commented Aug 22, 2024

What problem is this solving?

It relates to the task LOC-14868. The Localization team found some incorrect translations. And as they were fixed, we also took the chance to reorder the keys in alphabetical order, so their maintainability will be inproved for the next PRs.

Copy link

vtex-io-ci-cd bot commented Aug 22, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Aug 22, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Aug 22, 2024

Fails
🚫

Please remove the line ## [1.34.2] - 2024-09-03 from CHANGELOG.md
This will be automatically added once this PR is merged.

Warnings
⚠️

package.json was changed, but not yarn.lock (vice-versa) [:bulb: are you sure this is right?]

⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 4207, PR deletions = 4196

Generated by 🚫 dangerJS against 5f7c0bf

Copy link

sonarcloud bot commented Aug 22, 2024

Copy link
Contributor

@sheilagomes sheilagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sheilagomes and others added 2 commits September 3, 2024 17:03
Co-authored-by: Arthur Andrade <arthurfelandrade@gmail.com>
@ArthurTriis1
Copy link
Contributor

LGTM! Can you fix the conflicts?

@GeorgeLimaDev
Copy link
Contributor Author

LGTM! Can you fix the conflicts?
@ArthurTriis1, done! Do you prefer to go on with merge and deploy or can I do it?

@ArthurTriis1
Copy link
Contributor

LGTM! Can you fix the conflicts?
@ArthurTriis1, done! Do you prefer to go on with merge and deploy or can I do it?

Im doing, thanks!

@ArthurTriis1 ArthurTriis1 merged commit edcf80f into master Sep 5, 2024
9 of 11 checks passed
@ArthurTriis1 ArthurTriis1 deleted the loc/14868 branch September 5, 2024 12:52
Copy link

vtex-io-ci-cd bot commented Sep 5, 2024

Your PR has been merged! App is being published. 🚀
Version 1.34.2 → 1.34.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-organizations@1.34.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants