Skip to content

Commit

Permalink
ignore legacy minicart and fix lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasecdb committed Feb 5, 2020
1 parent 8d29cca commit d50661a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
node_modules
node_modules
react/legacy
react/index.js
1 change: 1 addition & 0 deletions react/CheckoutButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { FormattedMessage } from 'react-intl'
import { Button } from 'vtex.styleguide'
import { useCssHandles } from 'vtex.css-handles'
import { useCheckoutURL } from 'vtex.checkout-resources/Utils'

import useCheckout from './modules/checkoutHook'

interface Props {
Expand Down
1 change: 0 additions & 1 deletion react/Minicart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { useOrderForm } from 'vtex.order-manager/OrderForm'

import MinicartIconButton from './components/MinicartIconButton'
import DrawerMode from './components/DrawerMode'

import { MinicartContextProvider, useMinicartState } from './MinicartContext'
import PopupMode from './components/Popup'
import useCartIdPixel from './modules/useCartIdPixel'
Expand Down
2 changes: 1 addition & 1 deletion react/modules/debouncedPixelHook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ export default function useDebouncedPush() {
const debouncedPush = useRef<(param: object) => void>(debounce(push, 600))

return debouncedPush.current
}
}
4 changes: 2 additions & 2 deletions react/modules/pixelHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function mapCartItemToPixel(item: CartItem): PixelCartItem {
detailUrl: item.detailUrl,
imageUrl: item.imageUrls
? fixUrlProtocol(item.imageUrls.at3x)
: item.imageUrl || '',
: item.imageUrl ?? '',
}
}

Expand Down Expand Up @@ -43,7 +43,7 @@ function fixUrlProtocol(url: string) {
return url
}

return 'https:' + url
return `https:${url}`
}

/**
Expand Down

0 comments on commit d50661a

Please sign in to comment.