Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Patch 1 #13

wants to merge 6 commits into from

Conversation

ingmoyete
Copy link
Contributor

What problem is this solving?

Refactoring to load a javascript file

How should this be manually tested?
Install app and register oct8ne

Screenshots or example usage:
Not available

@ingmoyete ingmoyete requested a review from a team as a code owner October 28, 2021 06:27
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 28, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@ingmoyete ingmoyete requested review from icazevedo, victorhmp and RodrigoTadeuF and removed request for a team October 28, 2021 06:27
@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ingmoyete
Copy link
Contributor Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@ingmoyete
Copy link
Contributor Author

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ingmoyete
Copy link
Contributor Author

Hi,
Could we make this a major version?

@ingmoyete
Copy link
Contributor Author

Hi,
Cesar (cesarocampov) wants to see this branch, I gave him access to myrepo. Would be necessary to include him here as a reviewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant