Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: choose shipping facets to show #692

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

ArthurFerrao
Copy link
Contributor

What problem is this solving?

We need to allow the client to choose the shipping facets that will be shown in the filter.

How to test it?

Update the store-theme adding the availableShippingValues atribute in search-result-layout props.

"search-result-layout.desktop": {
    "children": [
      "flex-layout.row#searchbread",
      "flex-layout.row#searchtitle",
      "flex-layout.row#result"
    ],
    "props": {
      "availableShippingValues": [
        "pickup-nearby",
        "pickup-in-point",
        "delivery"
      ]
    }

Workspace

Screenshots or example usage:

image

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@ArthurFerrao ArthurFerrao self-assigned this Jan 10, 2025
@ArthurFerrao ArthurFerrao requested review from a team as code owners January 10, 2025 14:42
@ArthurFerrao ArthurFerrao requested review from gabpaladino, vsseixaso and leo-prange-vtex and removed request for a team January 10, 2025 14:42
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 10, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 10, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ArthurFerrao ArthurFerrao merged commit 6a163c6 into master Jan 16, 2025
8 checks passed
@ArthurFerrao ArthurFerrao deleted the feat/filter-shipping-facets branch January 16, 2025 19:42
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 16, 2025

Your PR has been merged! App is being published. 🚀
Version 3.135.0 → 3.136.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search-result@3.136.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants