feat: return empty array to a deprecated endpoint

vtex-apps · Sep 3, 2024 · 21238a8 · 21238a8
1 parent 4d2c52a
commit 21238a8
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/node/clients/checkout.ts b/node/clients/checkout.ts
@@ -220,8 +220,15 @@ export class Checkout extends JanusClient {
     })
   }
 
+  // Deprecated: This endpoint is deprecated and any request will return an empty array
   public orders = () =>
-    this.get(this.routes.orders, { metric: 'checkout-orders' })
+    this.get(this.routes.orders, { metric: 'checkout-orders' }).catch((err) => {
+      if (err.response && err.response.status === 405) {
+        return []
+      }
+
+      throw err
+    })
 
   public simulation = (simulation: SimulationPayload) =>
     this.post<SimulationOrderForm>(

diff --git a/node/resolvers/checkout/index.ts b/node/resolvers/checkout/index.ts
@@ -304,6 +304,20 @@ export const queries: Record<string, Resolver> = {
     return checkout.orders()
   },
 
+  // orders: async (_, __, { clients: { checkout } }) => {
+  //   try {
+  //     const result = await checkout.orders()
+
+  //     return result
+  //   } catch (err) {
+  //     if (err.response && err.response.status === 405) {
+  //       return []
+  //     }
+
+  //     throw err
+  //   }
+  // },
+
   shipping: (_, args: any, { clients: { checkout } }) => {
     return checkout.simulation(args)
   },