Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DNK postal code rules #619

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix DNK postal code rules #619

merged 1 commit into from
Oct 9, 2024

Conversation

GeorgeLimaDev
Copy link
Contributor

@GeorgeLimaDev GeorgeLimaDev commented Oct 7, 2024

What is the purpose of this pull request?

It relates to the task LOC-16864. It fixes the behavior in the field postalCode for DNK.

How should this be manually tested?

Accepted values now should be only 4 digits-long strings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link
Contributor

vtex-io-ci-cd bot commented Oct 7, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@GeorgeLimaDev GeorgeLimaDev marked this pull request as ready for review October 7, 2024 14:02
Copy link
Contributor

@kaio-donadelli kaio-donadelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GeorgeLimaDev GeorgeLimaDev merged commit 9c37345 into 4.x Oct 9, 2024
7 checks passed
@GeorgeLimaDev GeorgeLimaDev deleted the loc/16864-4x branch October 9, 2024 20:41
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 9, 2024

Your PR has been merged! App is being published. 🚀
Version 4.25.4 → 4.25.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.address-form@4.25.5

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants