feat(acessibility): added ARIA-label property #1447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0afbbd9:
|
filipewl
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Fala @joaocongio! Dá uma olhada neste meu outro comentário. Acredito que conseguimos resolver o seu caso sem necessitar essa mudanças daqui.
|
Como foi resolvido o PR do minicart (vtex-apps/minicart#331) sem a necessidade dessa adição, vou fechar esse PR, @joaocongio, se discordar por favor comenta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Adicionado a propriedade aria-label para resolver ajustes de acessibilidade apontados pelo Lighthouse.
PR relacionada: vtex-apps/minicart#331
What problem is this solving?
Running workspace
Executar teste no Lighthouse ou PageSpeed.
Screenshots or example usage
Antes da alteração:
Depois da alteração (o ajuste não foi mais apontado pelo Lighthouse):
Types of changes