function/function inserted into the element button for use in accessibility #1451
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| node_modules/ | ||
| coverage/ | ||
| *.snap.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,7 @@ | ||
| { | ||
| "extends": "vtex", | ||
| "root": true, | ||
| "env": { | ||
| "node": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1 @@ | ||
| "@vtex/prettier-config" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -215,6 +215,8 @@ class Button extends Component { | |||||
|
|
||||||
| return ( | ||||||
| <Element | ||||||
| role={this.props.role} | ||||||
| aria-label={this.props.ariaLabel} | ||||||
| id={this.props.id} | ||||||
| data-testid={this.props.testId} | ||||||
| autoFocus={iconOnly ? undefined : this.props.autoFocus} | ||||||
|
|
@@ -241,7 +243,8 @@ class Button extends Component { | |||||
| // Button-mode exclusive props | ||||||
| type={href ? undefined : this.props.type} | ||||||
| // Link-mode exclusive props | ||||||
| {...(href && linkModeProps)} | ||||||
| > | ||||||
| {isLoading ? ( | ||||||
| <Fragment> | ||||||
| <span className="vtex-button__spinner-container top-0 left-0 w-100 h-100 absolute flex justify-center items-center"> | ||||||
|
|
@@ -258,7 +261,8 @@ class Button extends Component { | |||||
| style={{ | ||||||
| paddingTop: '.25em', | ||||||
| paddingBottom: '.32em', | ||||||
| }} | ||||||
| > | ||||||
| {children} | ||||||
| </div> | ||||||
| )} | ||||||
|
|
@@ -281,6 +285,8 @@ Button.defaultProps = { | |||||
| isLastOfGroup: false, | ||||||
| isActiveOfGroup: false, | ||||||
| tabIndex: 0, | ||||||
| ariaLabel: 'button', | ||||||
|
There was a problem hiding this comment. The default aria-label value 'button' is not descriptive and may not provide meaningful information to screen readers. Consider using a more descriptive default or making this prop required when the button doesn't have visible text content.
Suggested change
|
||||||
| role: 'button', | ||||||
| } | ||||||
|
|
||||||
| Button.propTypes = { | ||||||
|
|
@@ -379,6 +385,10 @@ Button.propTypes = { | |||||
| noUpperCase: PropTypes.bool, | ||||||
| /** Disables label wrapping */ | ||||||
| noWrap: PropTypes.bool, | ||||||
| /** Aria label description */ | ||||||
| ariaLabel: PropTypes.string, | ||||||
| /** Role definition*/ | ||||||
|
There was a problem hiding this comment. Missing space before the closing comment delimiter. It should be '/** Role definition */'.
Suggested change
|
||||||
| role: PropTypes.string, | ||||||
| } | ||||||
|
|
||||||
| export default withForwardedRef(Button) | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'acessibility' is misspelled. It should be 'accessibility'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to apply this suggestion.