-
Notifications
You must be signed in to change notification settings - Fork 98
EDU-16243 - Input review #2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
EDU-16243 - Input review #2209
Conversation
Navigation Preview LinkNo changes detected in the navigation.json file |
Preview LinksOpen this URL to set up the portal with this branch changes. You can now access the edited pages with the following URLs:
|
Grammar review summaryReview for
|
</TokenTable> | ||
|
||
### Design tokens: Disabled | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabled inputs use reduced opacity and distinct styling to indicate when an input field is temporarily unavailable for interaction, preventing user input while maintaining visual context. | |
### ✅ Do's | ||
|
||
- Provide a [Label](https://developers.vtex.com/docs/guides/faststore/atoms-label) when using input. Descriptive labels help users understand the purpose of a form control. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use placeholder text as a hint or example of the expected input format, not as a replacement for labels. | |
- Ensure sufficient color contrast between text and background for accessibility. | |
- Use appropriate input types (e.g., email, name, phone number) to trigger the correct keyboard on mobile devices. | |
### ❌ Don'ts | |
- Don't use vague or ambiguous labels that leave users uncertain about what information to provide. | |
- Don't use inputs for long-form text entry. Use a [textarea](https://developers.vtex.com/docs/guides/faststore/atoms-textarea) component instead. | |
- Don't disable inputs without providing a clear reason why they're unavailable. | |
--- |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mariana Caetano Pereira <67270558+mariana-caetano@users.noreply.github.com>
Grammar review summaryReview for
|
|
||
[<i class="fa-brands fa-github"></i> Source code](https://github.com/vtex/faststore/tree/main/packages/components/src/atoms/Input) | ||
|
||
The `Input` component renders a single-line text field for capturing short user inputs. It serves as a means of collecting information from users. Typical use cases include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [Grammar reviewer] reported by reviewdog 🐶
The two sentences can be combined for better flow and conciseness. Additionally, 'user inputs' should be singular 'user input' as it refers to a general concept.
The `Input` component renders a single-line text field for capturing short user inputs. It serves as a means of collecting information from users. Typical use cases include: | |
The `Input` component renders a single-line text field for capturing short user input, serving as a means of collecting information from users. Typical use cases include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [Grammar reviewer] reported by reviewdog 🐶
When referring to the specific component, it should be capitalized and enclosed in backticks for consistency with other component references in the document. Also, the indefinite article 'an' is needed before 'Input'.
- Provide a [Label](https://developers.vtex.com/docs/guides/faststore/atoms-label) when using input. Descriptive labels help users understand the purpose of a form control. |
Types of changes