-
Notifications
You must be signed in to change notification settings - Fork 98
[FastStore UI] Review Label #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Navigation Preview LinkNo changes detected in the navigation.json file |
Preview LinksOpen this URL to set up the portal with this branch changes. You can now access the edited pages with the following URLs:
|
Grammar review summaryReview for
|
Grammar review summaryReview for
|
|
||
- Describing the purpose of input fields (e.g., `Email Address`, `Password`, or `Phone Number`). | ||
- Associating descriptive text with form elements for improved accessibility. | ||
- Providing context for user interactions in forms and surveys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [Grammar reviewer] reported by reviewdog 🐶
For consistency with the other bullet points in this list (lines 14 and 15), a period should be added at the end of the phrase.
- Providing context for user interactions in forms and surveys | |
- Providing context for user interactions in forms and surveys. |
### ❌ Don'ts | ||
|
||
- Don't use placeholder text as a substitute for labels, as placeholders disappear when users start typing. | ||
- Don't hide labels visually while keeping them only for screen readers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [Grammar reviewer] reported by reviewdog 🐶
The phrasing 'keeping them only for screen readers' is slightly informal. 'Making them accessible only to screen readers' is clearer and more precise in technical documentation.
- Don't hide labels visually while keeping them only for screen readers. | |
- Don't hide labels visually while making them accessible only to screen readers. |
Types of changes