Skip to content

Conversation

@julia-rabello
Copy link
Contributor

What is the purpose of this pull request?

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@julia-rabello julia-rabello self-assigned this Nov 6, 2025
@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 91bf57d
🔍 Latest deploy log https://app.netlify.com/projects/leafy-mooncake-7c2e5e/deploys/6920c5b241c35f00083d9278
😎 Deploy Preview https://deploy-preview-347--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']

}

try {
const fileContent = await getMarkdownFile(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui é melhor usar:

export async function fetchGitHubFileWithFallback(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usar funções ja existentes nesse arquivo o máx possível

Copy link
Contributor Author

@julia-rabello julia-rabello Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentei adaptar para usar essa função, mas o cdn fallback não funciona porque o repositório admin-docs-content é privado, dá File not found

res
.status(200)
.json(await getGithubTree('vtexdocs', 'admin-docs-content', 'main'))
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importante adicionar headers de cache que reduzem o número de requests necessárias.
Onde vai ser usada essa api?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acho que dá para fazer sem ela e buscar direto o conteúdo. fiz um commit apagando

@julia-rabello julia-rabello added release-no No release bump release-auto Automatic version bump and removed release-no No release bump labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-auto Automatic version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants