Handle range access on fragmented memory for hash and math modules. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthib
force-pushed
the
fragmented-range
branch
from
a657336 to
9261779
Compare
For some expressions, we want to be able to make them work even if regions are chunked. To do so, we need a new API to iterate on multiple distinct byte slices. This is done with the new Memory::on_range method. This uses a callback instead of returning an iterator to guarantee that only one region can be fetched at a given time, which is a constraint used in the memory trait.
vthib
force-pushed
the
fragmented-range
branch
from
9261779 to
a833bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some expressions, we want to be able to make them work even if regions are chunked. To do so, we need a new API to iterate on multiple distinct byte slices. This is done with the new Memory::on_range method.
This uses a callback instead of returning an iterator to guarantee that only one region can be fetched at a given time, which is a constraint used in the memory trait.