Add compiler profile to prioritize memory speed #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthib
force-pushed
the
add-compiler-profile
branch
from
cc1a657 to
b5c4dba
Compare
vthib
force-pushed
the
add-compiler-profile
branch
from
b5c4dba to
db7cbed
Compare
vthib
force-pushed
the
add-compiler-profile
branch
from
db7cbed to
1aa4624
Compare
Add a builder for the compiler object. This builder is only used for the moment to add modules, but more will be added. This builder solves an issue when adding modules, in that existing modules could not be replaced by the one added, which made for a much worse API and the impossibility of overwriting a module configuration with a new one. This is now solved as with a CompilerBuilder, it is guaranteed that added modules have not yet been used by any rules, so they can be replaced. This makes creating a compiler a bit more complex when custom modules are added, but this is not a huge change.
This avoids the "too many arguments" lint on Scanner::new, and will scale better.
Add a compiler profile option to CompilerBuilder. This will allow picking between: - speed: prioritize scanning speed (current impl & default) - memory: prioritize memory usage - automatic: pick between the two depending on the size of the rules. The memory profile is only implemented for the aho-corasick for the moment. Changing the regex engine used for validators could be an option, however it isn't trivial to do, and we would make implementing an "automatic" profile harder, since "automatic" only works if compilation is done when converting the compiler to the scanner.
vthib
force-pushed
the
add-compiler-profile
branch
from
1aa4624 to
4f44959
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 98.60% 98.60% -0.01%
==========================================
Files 80 81 +1
Lines 24507 24545 +38
==========================================
+ Hits 24166 24203 +37
- Misses 341 342 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: would be nice to run all tests on both profiles