Allow connection to unintrospectable signals #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method allows connection to signals using only GObject's own mechanisms. This is necessary for using unintrospectable classes such as those provided by Gst as LuaGObject's existing convenience mechanisms rely on introspection. Fixes #19
It was known that the port from GObject-Introspection to GI-Repository broke the info.fullname override and caused class names to display their underlying library name instead when printing, causing a disaster for debugging. A small fix was applied which made it so only the class name was shown instead. In fixing something unrelated, I discovered that the underlying cause of this bug was a bad logic error in the port to GI-Repository, fixed it, and restore the use of fullname where it was previously changed. This change also fixes the indentation of object.c to my preferred style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.