Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-multiple-template-root): support disallowComments property #2685

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chouchouji
Copy link

@chouchouji chouchouji commented Feb 14, 2025

Issue

resolve #2316

Todo

  • complete docs

@chouchouji
Copy link
Author

chouchouji commented Feb 14, 2025

@FloEdelmann I am confused about how to determine if it is the comment of the root node. So I choose to filter invalid comments by node ranges. If you have better idea, please tell me. Thanks!

<template>
  <!-- this is a comment --> // should report
   <div>
       123
       <!-- this is a comment --> // should not report
   </div>
   <!-- this is a comment --> // should report
</template>

@chouchouji chouchouji force-pushed the feat-disallow-comments branch from 3ed0157 to d93ffe2 Compare February 15, 2025 07:58
@chouchouji chouchouji force-pushed the feat-disallow-comments branch from d93ffe2 to 0cd3dff Compare February 15, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/no-multiple-template-root false negative with comment
1 participant