Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve printing experience. #4041

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

7086cmd
Copy link

@7086cmd 7086cmd commented Jul 14, 2024

In some cases, we may need to print documents as PDFs, using mdbook as an example. While certain components can be omitted during printing, there are situations where we might want to retain them. To address this, I am introducing an option to manage these components.

In the current implementation, I use the important key to emphasize hiding certain elements, which may lead to unintended side effects. I plan to remove these commands to avoid such issues.

Before

Before Image

After

After Image

With the removeExtraElementsInPrint option in DefaultTheme.Config, users can decide whether to keep or omit specific components during printing. Additionally, I have modified the dark mode switch function to automatically switch to light mode when the beforeprint event is triggered.


Let me know if any further changes are needed!

@7086cmd 7086cmd changed the title feat: remove navs and footers in printing mode. [WIP] feat: improve printing experience. [WIP] Jul 14, 2024
@7086cmd 7086cmd marked this pull request as ready for review July 14, 2024 12:43
@7086cmd 7086cmd changed the title feat: improve printing experience. [WIP] feat: improve printing experience. Jul 14, 2024
@7086cmd
Copy link
Author

7086cmd commented Jul 19, 2024

So strange. Local code are formatted, but online repo reported errors.

@brc-dd
Copy link
Member

brc-dd commented Jul 19, 2024

You seem to be using different prettier version. Try re-running pnpm install. Then pnpm format.

@7086cmd
Copy link
Author

7086cmd commented Jul 19, 2024

@brc-dd It works. Thanks!

@github-actions github-actions bot added the stale label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants