Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: lazy load shiki languages #4326

Merged
merged 3 commits into from
Oct 31, 2024
Merged

perf: lazy load shiki languages #4326

merged 3 commits into from
Oct 31, 2024

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 31, 2024

No description provided.

@brc-dd brc-dd merged commit 8299778 into main Oct 31, 2024
8 checks passed
@brc-dd brc-dd deleted the optimize-shiki branch October 31, 2024 12:10
@KnorpelSenf
Copy link

We are seeing ~75 % faster builds since we updated from vitepress 1.4.1 to 1.5.0 and this is the only pull request related to performance. Is that possible?

@brc-dd
Copy link
Member Author

brc-dd commented Nov 5, 2024

@KnorpelSenf There is #4321 too. Some projects are seeing over 88% faster builds. It depends on how many shiki languages you're using and how frequently you're using some code that depends on createMarkdownRenderer API.

@KnorpelSenf
Copy link

Thanks for explaining! We're using very few languages but a large number of code examples, so that matches up. Very cool changes!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants