docs(VDataTableServer): fixes pagination examples#20856
Merged
MajesticPotatoe merged 4 commits intovuetifyjs:masterfrom Jan 20, 2025
Merged
docs(VDataTableServer): fixes pagination examples#20856MajesticPotatoe merged 4 commits intovuetifyjs:masterfrom
MajesticPotatoe merged 4 commits intovuetifyjs:masterfrom
Conversation
MajesticPotatoe
approved these changes
Jan 20, 2025
MajesticPotatoe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When selecting the 'All' pagination setting, the table would display all rows except for the last one, which would be chopped off due to a minor issue in the pagination logic. I added a check to see if the 'end' variable was -1 and if so, set the end parameter of the slice to undefined so it returns the whole array of items. I wanted to make this change to ensure that if anyone used the pagination logic included in the examples as a reference for their own, this minor issue wouldn't slip through the cracks and cause problems.