Skip to content

Update BlindSQLInjectionVulnerability.java #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geokar01 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update BlindSQLInjectionVulnerability.java #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions ...java/org/sasanlabs/service/vulnerability/sqlInjection/BlindSQLInjectionVulnerability.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,11 @@ public ResponseEntity<String> getCarInformationLevel1(
@RequestParam Map<String, String> queryParams) {
String id = queryParams.get(Constants.ID);
BodyBuilder bodyBuilder = ResponseEntity.status(HttpStatus.OK);

// Use parameterized query to avoid SQL injection and select only needed column(s)
return applicationJdbcTemplate.query(
"select * from cars where id=" + id,
"SELECT id FROM cars WHERE id = ?",
new Object[] {id},
(rs) -> {
if (rs.next()) {
return bodyBuilder.body(CAR_IS_PRESENT_RESPONSE);
Expand All @@ -72,9 +75,11 @@ public ResponseEntity<String> getCarInformationLevel2(
@RequestParam Map<String, String> queryParams) {
String id = queryParams.get(Constants.ID);
BodyBuilder bodyBuilder = ResponseEntity.status(HttpStatus.OK);
bodyBuilder.body(ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);

// Parameterized query (even if originally wrapped with quotes)
return applicationJdbcTemplate.query(
"select * from cars where id='" + id + "'",
"SELECT id FROM cars WHERE id = ?",
new Object[] {id},
(rs) -> {
if (rs.next()) {
return bodyBuilder.body(CAR_IS_PRESENT_RESPONSE);
Expand All @@ -92,9 +97,10 @@ public ResponseEntity<String> getCarInformationLevel3(
@RequestParam Map<String, String> queryParams) {
String id = queryParams.get(Constants.ID);
BodyBuilder bodyBuilder = ResponseEntity.status(HttpStatus.OK);
bodyBuilder.body(ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);

// Prepared statement with parameter; select specific column(s) instead of '*'
return applicationJdbcTemplate.query(
(conn) -> conn.prepareStatement("select * from cars where id=?"),
(conn) -> conn.prepareStatement("SELECT id FROM cars WHERE id = ?"),
(prepareStatement) -> {
prepareStatement.setString(1, id);
},
Expand Down