Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in README.md #267

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix broken link in README.md #267

merged 1 commit into from
Dec 17, 2024

Conversation

JoeyC-Dev
Copy link
Contributor

@JoeyC-Dev JoeyC-Dev commented Dec 17, 2024

Description

Simply fix the link path cuz the current link is pointing to the 404.
image

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

Copy link

Unit Tests and Coverage

Show Output
	github.com/vultr/vultr-csi/cmd/csi-vultr-driver		coverage: 0.0%25 of statements%0A=== RUN   TestCreateVolume%0Atime="2024-12-13T00:41:52Z" level=info msg="Create Volume: called" capabilities="[mount:{} access_mode:{mode:SINGLE_NODE_WRITER}]" test="create volume" volume-name=volume-test-name%0Atime="2024-12-13T00:41:53Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-12-13T00:41:53Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-12-13T00:41:53Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-12-13T00:41:53Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-12-13T00:41:53Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-12-13T00:41:53Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-12-13T00:41:53Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0Acoverage: 28.3%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	(cached)	coverage: 28.3%25 of statements

Pusher: @JoeyC-Dev, Action: pull_request_target

Copy link
Contributor

@happytreees happytreees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@happytreees happytreees added the documentation Improvements or additions to documentation label Dec 17, 2024
@happytreees
Copy link
Contributor

Hello @JoeyC-Dev , thank you for you contribution!

@happytreees happytreees merged commit 98532b4 into vultr:master Dec 17, 2024
6 checks passed
@JoeyC-Dev JoeyC-Dev deleted the patch-1 branch December 17, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants