-
Notifications
You must be signed in to change notification settings - Fork 2
Added lower bound functionality (#7) #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -266,4 +266,42 @@ TEST_F(test_transaction, trivial_types_dup_iterate_by_key) | |
| ASSERT_TRUE(result); | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there is a small bug in |
||
| } | ||
|
|
||
| TEST_F(test_transaction, trivial_types_transaction_lower_bound) | ||
| { | ||
| std::array<uint8_t, 4> test_value{0x30, 0x0, 0x0, 0x20}; | ||
|
|
||
| lmdb:: | ||
| transaction<test_trait, lmdb::read_only_t::no, StrictMock<mocks::api>> | ||
| transaction{test_dbi, std::move(txn)}; | ||
|
|
||
| auto *cursor{reinterpret_cast<MDB_cursor *>(0x84)}; | ||
|
|
||
| { | ||
| InSequence const seq; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be great to have basic integration test as well. |
||
|
|
||
| EXPECT_CALL(api, mdb_cursor_open(test_txn, test_dbi, _)) | ||
| .WillOnce(DoAll(SetArgPointee<2>(cursor), Return(MDB_SUCCESS))); | ||
|
|
||
| EXPECT_CALL(api, mdb_cursor_get(cursor, Pointee(MdbValBytesAre{0x78, 0x56, 0x34, 0x12}), _, MDB_SET_RANGE)) | ||
| .WillOnce(DoAll( | ||
| SetArgPointee<2>( | ||
| MDB_val{test_value.size(), test_value.data()}), | ||
| Return(MDB_SUCCESS))); | ||
|
|
||
| EXPECT_CALL(api, mdb_cursor_close(cursor)); | ||
| EXPECT_CALL(api, mdb_txn_abort(test_txn)); | ||
| } | ||
|
|
||
| const auto result = transaction.lower_bound(0x12345678); | ||
| ASSERT_TRUE(result); | ||
|
|
||
| auto const& db_view = *result; | ||
| auto const it = db_view.begin(); | ||
| EXPECT_NE(it, db_view.end()); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use |
||
|
|
||
| auto const& key_value = *it; | ||
| EXPECT_EQ(key_value.key(), 0x12345678); | ||
| EXPECT_EQ(key_value.value(), 0x20000030); | ||
| } | ||
|
|
||
| } // namespace cpp_lmdb_tests | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to rename
db_dup_viewinto something likedb_view_with_keyas it is now used not only in key duplicate scenarios