Improve Coverage

vvromanov · Dec 8, 2024 · 2605a19 · 2605a19
1 parent 4f51c2d
commit 2605a19
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/HistoryCounters.cpp b/src/HistoryCounters.cpp
@@ -31,13 +31,6 @@ HistoryCounterData *HistoryCounters::GetCounterPtr(const char *name) {
 }
 
 HistoryCounters::index_t HistoryCounters::GetCounterIndex(const char *name) {
-    {
-        READ_LOCK;
-        auto index = GetData()->dict.Lookup(name);
-        if (index != DICTIONARY_INVALID_INDEX) {
-            return index;
-        }
-    }
     WRITE_LOCK;
     auto index = GetData()->dict.Lookup(name);
     if (index != DICTIONARY_INVALID_INDEX) {

diff --git a/tests/TestHistoryCounters.cpp b/tests/TestHistoryCounters.cpp
@@ -23,6 +23,7 @@ TEST_F(TestHistoryCounters, GetIndex) {
 		char cn[100];
 		snprintf(cn, sizeof(cn), TEST_COUNTER ".%05d", i);
 		EXPECT_EQ(i, GetHistoryCounters().GetCounterIndex(cn));
+		EXPECT_EQ(i, GetHistoryCounters().GetCounterIndex(cn));
 	}
 	EXPECT_EQ(DICTIONARY_INVALID_INDEX, GetHistoryCounters().GetCounterIndex("xxx"));
 }
@@ -91,7 +92,7 @@ TEST_F(TestHistoryCounters, DumpRaw) {
 	));
 	EXPECT_TRUE(HC_TestDump(format_raw,
 		"",
-		"XXX"
+		"test.level1.level2"
 	));
 }